joh/cruel hoverfly #155276
Merged
joh/cruel hoverfly #155276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbatten
previously approved these changes
Jul 15, 2022
sbatten
approved these changes
Jul 15, 2022
deepak1556
reviewed
Jul 20, 2022
Comment on lines
+300
to
+301
| this._win.setEnabled(false); | ||
| this._win.setEnabled(true); |
There was a problem hiding this comment.
These end up calling EnableWindow on windows with the toggled state https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-enablewindow. What is the reasoning to disable the window ?
sbatten
added a commit
that referenced
this pull request
Jul 20, 2022
sbatten
added a commit
that referenced
this pull request
Jul 21, 2022
* removing unnecessary enablements refs #155276 * add some comments * address feedback, bring back enablements but comment them
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TitleBarContexttoTitleBarTitleContextbecause that's what it isresolves Allow showing and hiding individual items in the title bar with a right-click menu #155345