vscode.workspace.applyEdit should honour the files.refactoring.autosave config

[a-stewart]

This PR fixes #112109

This adds a proposed api change, which adds a flag, specifying whether the applyEdit method in the vscode api should honour the files.refactoring.autosave config.

This seems like it would be the appropriate fix for #112109 since we are giving extensions the option to honour the users preference.

I have also added a config option minResourcesToAutosave to the bulk edit options, since by default, it would only auto save if 2 or more files where changed, but this preference would result in some very confusing behaviour for extension authors, so by adding a config option, we can set that to 1 or more files when called by an extension.

One potential issue is that, it seems like autosaving means that files aren't noted as being dirty and therefore don't open by default.

This is more a first pass at a solution than a proposed final result, but it would be good to discuss how you think we should surface this functionality.

[a-stewart]

Hi @jrieken - I was wondering if you had an opinion on this? Is this a direction you think it would be good to go in?

[jrieken]

Sorry - I have been swapped recently and I am now heading out to a longer vacation. My plan is to finally pick this up in August. Thanks for being patient.

[jrieken]

Thanks. This is looking good already but I left some comments here and there

[a-stewart]

Hi,

Sorry I missed your replying to this FR - thanks for applying this change.

A couple of comments:
src/vs/workbench/api/common/extHost.protocol.ts:241
$tryApplyWorkspaceEdit(workspaceEditDto: IWorkspaceEditDto, undoRedoGroupId?: number, respectAutoSaveConfig?: boolean): Promise<boolean>;

Should respectAutoSaveConfig be renamed to isRefactoring? It's an interface so not technical issue, but might be clearer.

Regarding minResourcesToAutosave - the idea behind this was there is a different behaviour if a bulk edit only effects one file. I am not sure if there is a legacy reason for this in the core of VS Code so I didn't want to change anything there, but when auto-safe is requested by an extension, it is slightly confusing if it doesn't apply in some situations.

Perhaps we could remove the > 1 check in src/vs/workbench/contrib/bulkEdit/browser/bulkEditService.ts? But if it is required by the core? Perhaps we could pass the isRefactoring param through and or with that?