Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes detaching a terminal editor doesn't fire vscode.window.onDidCloseTerminal event #152791

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Fixes detaching a terminal editor doesn't fire vscode.window.onDidCloseTerminal event #152791

merged 1 commit into from
Jun 21, 2022

Conversation

jeanp413
Copy link
Contributor

This PR fixes #152785

Tyriar
Tyriar approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works. This is one of the problems called out in #152302

@Tyriar Tyriar added this to the June 2022 milestone Jun 21, 2022
@Tyriar Tyriar mentioned this pull request Jun 21, 2022
Closed
@Tyriar Tyriar merged commit aae33f1 into microsoft:main Jun 21, 2022
@jeanp413 jeanp413 deleted the fix-152785 branch June 21, 2022 21:48
@Tyriar Tyriar mentioned this pull request Jun 28, 2022
Closed
This was referenced Jul 8, 2022
Merged
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joyceerhl joyceerhl joyceerhl approved these changes

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
June 2022
Development

Successfully merging this pull request may close these issues.

Detaching a terminal editor doesn't fire vscode.window.onDidCloseTerminal event
3 participants
@jeanp413 @Tyriar @joyceerhl