Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default override model value #150232

Merged
merged 1 commit into from
May 24, 2022
Merged

Fix default override model value #150232

merged 1 commit into from
May 24, 2022

Conversation

rzhao271
Copy link
Contributor

Fixes #150231.
This PR also:

  1. Changes one of the field names in the ISetting interface to emphasize that that interface holds the non-language-specific default value source.
  2. Fixes a bug where there was an extra colon; LANGUAGE_SETTING_TAG already ends with a colon.

@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug debt Code quality issues labels May 23, 2022
@rzhao271 rzhao271 added this to the May 2022 milestone May 23, 2022
@rzhao271 rzhao271 self-assigned this May 23, 2022
@rzhao271 rzhao271 merged commit ac0a282 into main May 24, 2022
@rzhao271 rzhao271 deleted the rzhao271/default-value-fix branch May 24, 2022 15:33
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mjbvz mjbvz mjbvz approved these changes

Assignees

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues
Projects
None yet
Milestone
May 2022
Development

Successfully merging this pull request may close these issues.

Language-specific default override indicator fails to update
2 participants
@rzhao271 @mjbvz