Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor Drop Target debug threshold square cleanup #149570

Merged
merged 1 commit into from
May 30, 2022
Merged

Editor Drop Target debug threshold square cleanup #149570

merged 1 commit into from
May 30, 2022

Conversation

MachineMitch21
Copy link
Contributor

This PR fixes #149569

@roblourens roblourens assigned mjbvz and unassigned roblourens May 17, 2022
@mjbvz mjbvz assigned bpasero and unassigned mjbvz May 17, 2022
@bpasero bpasero added this to the June 2022 milestone May 27, 2022
bpasero
bpasero requested changes May 28, 2022
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks but I feel we can just remove this code, I have never used it since. Wanna remove it?

@MachineMitch21 MachineMitch21 force-pushed the editor_drop_target_debug_overlay_update branch from 33d1f2e to 2c0c3aa Compare May 28, 2022 22:11
@MachineMitch21 MachineMitch21 force-pushed the editor_drop_target_debug_overlay_update branch from 998f5d5 to 7446da5 Compare May 28, 2022 22:20
@MachineMitch21
Copy link
Contributor Author

Yep, not a problem. Pushed up an amendment which just removes the code :)

@bpasero bpasero modified the milestones: June 2022, May 2022 May 29, 2022
@bpasero bpasero enabled auto-merge (squash) May 30, 2022 04:49
@bpasero bpasero merged commit 88d9a08 into microsoft:main May 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
May 2022
Development

Successfully merging this pull request may close these issues.

Drop threshold debug square broken currently
4 participants
@MachineMitch21 @bpasero @roblourens @mjbvz