Added extension search text length to telemetry

[prashantvc]

This PR adds the length of search text to the telemetry

[isidorn]

This looks ok to me, but I leave the final review to @sandy081 as he would know best if this catches all the cases where we have the searchText .

@prashantvc did you try this out, if it catches the data you need in all cases. To build VS Code out of source just follow this doc https://github.com/microsoft/vscode/wiki/How-to-Contribute
And then you can check the telemetry output log to see if the query length is being captured as you intended.

[prashantvc]

And then you can check the telemetry output log to see if the query length is being captured as you intended.

Yes, I tried it locally on my machine! It seems to capture the data that I need

[sandy081]

This is not the right location to add data for telemetry and this method is not needed. You can add following code

searchtextLength: this.searchText.length

in the following location

vscode/src/vs/platform/extensionManagement/common/extensionGalleryService.ts

Line 350 in 310108c

source: this.state.source

and add this property in the telemetry classification here

vscode/src/vs/platform/extensionManagement/common/extensionGalleryService.ts

Line 242 in 310108c

readonly pageNumber: { classification: 'SystemMetaData'; purpose: 'FeatureInsight' };

and

vscode/src/vs/platform/extensionManagement/common/extensionGalleryService.ts

Line 259 in 310108c

readonly source?: string;

[prashantvc]

Thanks for review fixing them now

[isidorn]

@prashantvc let us know when this is good for review again. Thank you

[prashantvc]

let us know when this is good for review again. Thank you

It's ready now

[sandy081]

LGTM - Thanks

[isidorn]

Looks good, thanks a lot @prashantvc
Let's merge this in.