allow null in ICodeEditor.restoreViewState() #146866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the state parameter type of `ICodeEditor.restoreViewState()` to match the return type of `ICodeEditor.saveViewState()` ([source](https://github.com/microsoft/vscode/blob/3698a0b247d7c252b31bd25631647911328ae513/src/vs/monaco.d.ts#L2354)). The implementing function allows null as seen in [the source](https://github.com/microsoft/vscode/blob/b57db0fc49ee5777a4e02e8936f5b8cb9fb6182d/src/vs/editor/browser/widget/codeEditorWidget.ts#L995).
alexdima
approved these changes
May 11, 2022
rebornix
approved these changes
May 11, 2022
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the state parameter type of
ICodeEditor.restoreViewState()to match the return type ofICodeEditor.saveViewState()(source).The implementing function allows null as seen in the source.
This PR fixes #