fix #130527 #146710
Merged
fix #130527 #146710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a good find/fix but I doubt that it fixes the original issue of not previewing enough, right? |
|
yes, that can fix the problem |
|
@jrieken hi~, is it possible to merge this PR into it？ |
jrieken
approved these changes
May 6, 2022
|
I took me a while to understand (my own code) how this fixes the problem... Thanks for the contribution |
alexdima
approved these changes
May 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #130527, 'findTokenIndexAtOffset' parameter is calculated from 0, but we use the range parameter is calculated from 1
This PR fixes #130527
'findTokenIndexAtOffset' parameter is calculated from 0, but we use the range parameter is calculated from 1