-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for references when no [] exists #144781
Conversation
Thanks for taking a look! Can you please also add tests for this: vscode/extensions/markdown-language-features/src/test/documentLinkProvider.test.ts Line 15 in 7ccb868
In the tests, also try adding test for potential edge cases or false positives where link detection should not occur I'm also inclined to say that the link detection should not kick in for |
Will do! |
Sorry for the delay. Should be ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable overall. Thanks for following up!
Can you please remove the binary file added under ./scripts
though? Looks like it was committed by mistake
Whoops! My bad for littering. Should be fixed, thanks for the heads up! |
Thanks! Will be in the next insiders build |
This PR fixes #141285
Code has been updated with the
main
branch and I have personally reviewed it.Changes
Alters the regex to match [...] and [...][...]. Treats [...] as if it's the same as [...][].
Testing
On the feature branch:
Markdown: Open Preview
from the Command Palette.Expected Output