Add option to not pass --no-ignore-parent to rg #140022
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@roblourens This PR fixes #118229. You can test it using these steps:
foo/
, run the following command:foo/.gitignore
:baz.txt
foo/bar/baz.txt
:foo/bar/
.baz
: the filebaz.txt
should appear.qux
: its appearance inbaz.txt
should appear.baz.txt
in VS Code in step 7 or 8, run Go to File... again and click the "X" next tobaz.txt
(it would say "recently opened" in that case).I wrote this by piggybacking off of #59717: I searched for the string
GlobalIgnoreFiles
in the codebase and added similar code forParentIgnoreFiles
alongside each occurrence I found. Please let me know if I missed anything, or if I should add any automated tests to accompany the code changes.