Single view cell state event listener #137486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
Nov 19, 2021
| @@ -86,6 +86,19 @@ export class CellEditorOptions extends Disposable { | |||
| this._value = this._computeEditorOptions(); | |||
| } | |||
|
|
|||
| prepareRender(): void { | |||
There was a problem hiding this comment.
It could be optional to implement these, seems that parts often don't need to
There was a problem hiding this comment.
not everyone needs updateLayoutNow either so we can probably use override other than abstract
There was a problem hiding this comment.
I might still keep it though to ensure that when we add a new CellPart, we are aware that batching DOM read and writes are necessary.
roblourens
reviewed
Nov 19, 2021
| } | ||
|
|
||
| if (e.inputCollapsedChanged) { | ||
| this.templateData.progressBar.updateForCellState(this.viewCell); |
There was a problem hiding this comment.
The progress bar can be a cell part right?
There was a problem hiding this comment.
@roblourens yes, it would make good sense to make it a cell part.
roblourens
approved these changes
Nov 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #131808.
This PR implements
CellPart#updateStateand registers a single event listener for view cell state change.