Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fold jumping with no parent fold #130309

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Fix fold jumping with no parent fold #130309

merged 1 commit into from
Aug 17, 2021

Conversation

ssigwart
Copy link
Contributor

@ssigwart ssigwart commented Aug 7, 2021

This PR fixes #129503

This makes it so "Go to Next Fold" and "Go To Previous Fold" work when you are not in a fold region or are in a fold region at the root level.

To test, run this:

./scripts/test.sh --glob **/foldingModel.test.js --grep fold

@aeschli aeschli merged commit 99cd300 into microsoft:main Aug 17, 2021
@aeschli aeschli added this to the September 2021 milestone Aug 17, 2021
@aeschli aeschli added the editor-folding Editor code folding issues label Aug 17, 2021
@aeschli
Copy link
Contributor

aeschli commented Aug 17, 2021

Thanks @ssigwart !

@ssigwart ssigwart deleted the foldFix branch August 18, 2021 00:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-folding Editor code folding issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Folding Navigation Commands Sometimes Don't Work
2 participants