A run & debug dropdown with default button #128022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weinand
added
the
debug
weinand
changed the title
| @@ -304,14 +308,142 @@ export class SubmenuEntryActionViewItem extends DropdownMenuActionViewItem { | |||
| } | |||
| } | |||
|
|
|||
| class DropdownWithDefauktActionViewItem extends BaseActionViewItem { | |||
There was a problem hiding this comment.
Defaukt is probably intended to be Default
There was a problem hiding this comment.
Indeed - thanks for spotting this.
jrieken
approved these changes
Jul 6, 2021
|
Yeah, I was using the menu identifier as a storage key before but decided differently when polishing the PR... ;-) |
|
Incorporated @jrieken's feedback. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #117722
This is my first attempt for a dropdown menu that remembers a default action.
The PR introduces an alternative UI for submenus:
If a "storageKey" attribute is specified for a submenu, the submenu is shown in the UI as a dropdown menu with a button that executes the last action run from the dropdown. The default action is persisted in workspace storage under the "storageKey".
This alternate UI is generic (independent from debug's run & debug functionality).
However, this PR configures the alternate UI for the "editor/title/run" contribution point.
The UI looks like this: