Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macos - restore Cmd+W to close window when no editors opened #126045

Merged
merged 1 commit into from
Jun 14, 2021
Merged

macos - restore Cmd+W to close window when no editors opened #126045

merged 1 commit into from
Jun 14, 2021

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Jun 11, 2021

This PR fixes #126042

@bpasero bpasero added the candidate Issue identified as probable candidate for fixing in the next release label Jun 11, 2021
@bpasero bpasero added this to the May 2021 Recovery milestone Jun 11, 2021
@bpasero bpasero requested a review from isidorn June 11, 2021 13:16
@bpasero bpasero self-assigned this Jun 11, 2021
@isidorn
Copy link
Contributor

isidorn commented Jun 11, 2021

The code looks good, I have also tried this out and this works as expected. I also think this behaviour makes a lot of sense for macOS -> approved

@bpasero bpasero merged commit 6bca69f into release/1.57 Jun 14, 2021
@bpasero bpasero deleted the ben/macos-cmdw branch June 14, 2021 08:47
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@isidorn isidorn isidorn approved these changes

Assignees

@bpasero bpasero

Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Milestone
May 2021 Recovery
Development

Successfully merging this pull request may close these issues.
2 participants
@bpasero @isidorn