Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve repl filter value through reloads #125221

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Preserve repl filter value through reloads #125221

merged 2 commits into from
Jun 2, 2021

Conversation

jeanp413
Copy link
Contributor

@jeanp413 jeanp413 commented Jun 2, 2021

This PR fixes #125035

@jeanp413 jeanp413 mentioned this pull request Jun 2, 2021
Closed
@isidorn isidorn assigned isidorn and unassigned weinand Jun 2, 2021
@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jun 2, 2021
@isidorn
Copy link
Contributor

isidorn commented Jun 2, 2021 •
edited
Loading

@jeanp413 the code changes look great.
However I just tried it out and there is one issue which we might need to fix to make this experience nice

  1. Start debugging. Set some filter -> notice how the filter gets applied and not everything is displayed in the debug console
  2. Stop debugging. Reload window
  3. Start debugging. Notice the filter is now nicely preserved and is set in input. However the filter is not applied, I can see all the content in the debug console - it is not filtered 🐛

@jeanp413
Copy link
Contributor Author

jeanp413 commented Jun 2, 2021

@isidorn thanks for catching that, pushed the fix for it

@isidorn
Copy link
Contributor

isidorn commented Jun 2, 2021 •
edited
Loading

This works great now -> merged.
Thanks again for helping make VS code awesome 👏

@isidorn isidorn merged commit 26ff863 into microsoft:main Jun 2, 2021
@isidorn isidorn added this to the May 2021 milestone Jun 2, 2021
@jeanp413 jeanp413 deleted the fix-125035 branch June 2, 2021 16:02
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@isidorn isidorn

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Milestone
May 2021
Development

Successfully merging this pull request may close these issues.

Debug Console filter text should be preserved across reloads
3 participants
@jeanp413 @isidorn @weinand