Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #123831 handle command URL in ErrorResponse Message from debug adapter #123833

Merged
merged 1 commit into from
May 14, 2021

Conversation

gjsjohnmurray
Copy link
Contributor

This PR fixes #123831

/assign @isidorn

@isidorn
Copy link
Contributor

isidorn commented May 14, 2021

Yes I think we explicitly decided that the clients have to specify that they allow commands to be run.
Since this url is coming from an extension, which can already run any command this is fine.
Thus approved and merging

fyi @jrieken

@gjsjohnmurray thanks a lot for this PR!

@isidorn isidorn added this to the May 2021 milestone May 14, 2021
@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label May 14, 2021
@isidorn isidorn merged commit 27966a2 into microsoft:main May 14, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2021
@gjsjohnmurray gjsjohnmurray deleted the fix-123831 branch August 16, 2024 04:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command URL in debug extension ErrorResponse Message is ignored
2 participants