Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes long ouput with wrapped lines in narrow terminal crashes vscode #117734

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Fixes long ouput with wrapped lines in narrow terminal crashes vscode #117734

merged 1 commit into from
Feb 26, 2021

Conversation

jeanp413
Copy link
Contributor

The endLine variable was being incremented indefinitely because getLine() wraps around the underlying circular list buffer and all the lines in the buffer have isWrapped set to true

This PR fixes #117682

@jeanp413 jeanp413 mentioned this pull request Feb 26, 2021
Closed
@Tyriar Tyriar added this to the March 2021 milestone Feb 26, 2021
Tyriar
Tyriar approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into it!

@Tyriar Tyriar merged commit d0a46a0 into microsoft:main Feb 26, 2021
@jeanp413 jeanp413 deleted the fix-117682 branch February 26, 2021 21:35
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
March 2021
Development

Successfully merging this pull request may close these issues.

Terminal too narrow: Output with long lines (wrapping) freezes/crashes vscode
3 participants
@jeanp413 @Tyriar @meganrogge