Migrate to new deb repo #114527
Merged
Migrate to new deb repo #114527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
commented
Jan 18, 2021
Comment on lines
-98
to
-102
| .pipe(replace('@@ARCHITECTURE@@', debArch)) | ||
| .pipe(replace('@@QUALITY@@', product.quality || '@@QUALITY@@')) | ||
| .pipe(replace('@@UPDATEURL@@', product.updateUrl || '@@UPDATEURL@@')) | ||
| .pipe(replace('@@REPOSITORY_NAME@@', arch === 'x64' ? 'vscode' : 'code')) | ||
| .pipe(replace('@@SUPPORTED_ARCHITECTURES@@', arch === 'x64' ? 'amd64' : 'amd64,arm64,armhf')) |
There was a problem hiding this comment.
@Tyriar None of these were being used.
| # Write source list if it was disabled by OS upgrade | ||
| WRITE_SOURCE=1 | ||
| fi | ||
| if [ "$WRITE_SOURCE" -eq "1" ]; then | ||
| echo "### THIS FILE IS AUTOMATICALLY CONFIGURED ### | ||
| # You may comment out this entry, but any other modifications may be lost. | ||
| deb [arch=@@SUPPORTED_ARCHITECTURES@@] http://packages.microsoft.com/repos/@@REPOSITORY_NAME@@ stable main" > $CODE_SOURCE_PART | ||
| deb [arch=amd64,arm64,armhf] http://packages.microsoft.com/repos/code stable main" > $CODE_SOURCE_PART |
There was a problem hiding this comment.
@Tyriar Any specific reason why we're using http here instead of https?
There was a problem hiding this comment.
Yes, supporting https requires additional packages from being installs and package integrity is covered by the signing. When I tried to change this earlier I got push back from community because of this, since then I've also had other people try changing it to https 🤷
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #106473
cc @Tyriar