Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet tweaks: remove extra languages from conditions #11001

Merged
merged 3 commits into from
Aug 28, 2016
Merged

Emmet tweaks: remove extra languages from conditions #11001

merged 3 commits into from
Aug 28, 2016

Conversation

mrmlnc
Copy link
Contributor

@mrmlnc mrmlnc commented Aug 26, 2016

Source: #9500

The following languages can be removed from the condition:

  • twig by TwigPack extension and twig by Twig extension
  • ejs by .ejs extension
  • erb by erb extension
  • php by vscode extension
  • hbs === handlebars (We work with identifiers)

The following languages cannot be removed because it does not have scopeNames:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.967% when pulling 3c338e0 on mrmlnc:fix-emmet-conditions into 6ae0573 on Microsoft:master.

@egamma egamma merged commit c6a1d67 into microsoft:master Aug 28, 2016
@egamma
Copy link
Member

egamma commented Aug 28, 2016

👍 thanks!

@egamma egamma added this to the August 2016 milestone Sep 5, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants