Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closes #97890 #108779

Merged
merged 2 commits into from
Oct 19, 2020
Merged

closes #97890 #108779

merged 2 commits into from
Oct 19, 2020

Conversation

a5hk
Copy link
Contributor

@a5hk a5hk commented Oct 16, 2020

This PR fixes #97890

@joaomoreno joaomoreno assigned aeschli and unassigned joaomoreno Oct 16, 2020
@a5hk
Copy link
Contributor Author

a5hk commented Oct 17, 2020

yarn test-browser --browser firefox --browser chromium completes without errors locally for me on windows.

@aeschli aeschli added this to the October 2020 milestone Oct 19, 2020
@aeschli aeschli merged commit db8ff25 into microsoft:master Oct 19, 2020
@aeschli
Copy link
Contributor

aeschli commented Oct 19, 2020

Thanks @a5hk !

@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
October 2020
Development

Successfully merging this pull request may close these issues.

One token foreground rule per line for semantic tokens in token inspector window
3 participants
@a5hk @aeschli @joaomoreno