use trusted types policy and sanitizer for static authored help contents #108332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable... though I do have to wonder what benefit we get using hyper-specific allow lists as opposed to a general "allow things that can't run js" policy. I foresee at least one head-banging session caused by forgetting to update the list 🙃 |
JacksonKearl
approved these changes
Oct 8, 2020
Fully agree but I couldn't figure out to configure insane that way |
|
fyi - pushed a few generalisations so that the issue reporter (and static html in general) can use this. This is now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #106395 and makes sure we use a trusted types policy when rendering static help content as html