-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: detect default stash message microsoft#106907 #107074
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put this behind a setting. The text in the commit box might be equal to the commit template, which would be a poor indicator of a good stash message. Optionally, we can compare the value against the last known template message and only use it if it doesn't equal the template message.
By setting do you mean, a setting in preferences to toggle whether to use commit message as default stash message? If so, can you give me a hint on how to do it? Sorry I never used git commit template, so I didn't knew about it. I can change the code. Edit-1: Updated question. |
Yes, a user setting that can be configured. When I am looking to add a setting, I search for a setting that I know exists. Then kind of follow what was needed to implement it. For example, you could search for “search.actionsPosition” in the src folder. Then you should be able to find it and see what sort of implementation you need. (It may be better to search for a git setting, so you’re in the same area already.) Somebody else may be able to give you better details about what exactly is required. I don’t work in it enough to know the specifics. |
I figured that out and already added in commit 94ab148 in my fork. |
use commit message as default stash message if commit message box is populated
@joaomoreno Is this PR still in review? |
This PR fixes #106907
Use commit message as default stash message if commit message box is populated.