Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screencast Mode add Custom color and size #105103

Closed
wants to merge 2 commits into from
Closed

Screencast Mode add Custom color and size #105103

wants to merge 2 commits into from

Conversation

d1y
Copy link
Contributor

@d1y d1y commented Aug 20, 2020

I like vscode very much and hope this proposal can be passed

Thank you 🙈

@ghost
Copy link

ghost commented Aug 20, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@d1y
Copy link
Contributor Author

d1y commented Aug 20, 2020

@lszomoru

@lszomoru lszomoru self-requested a review August 21, 2020 09:14
@lszomoru lszomoru assigned lszomoru and unassigned joaomoreno Aug 21, 2020
@lszomoru lszomoru added this to the August 2020 milestone Aug 21, 2020
@lszomoru
Copy link
Member

@d1y , thank you very much for the contribution. I will take a look at the pull request next week.

@d1y
Copy link
Contributor Author

d1y commented Aug 26, 2020

Hello, brother. How is the progress

@lszomoru

@lszomoru
Copy link
Member

@d1y, looks like you have deleted your remote.
I need to make some minor changes to the code so I will create a new PR, and will mark you are a co-author.

@d1y
Copy link
Contributor Author

d1y commented Aug 28, 2020

@d1y, looks like you have deleted your remote.
I need to make some minor changes to the code so I will create a new PR, and will mark you are a co-author.

What do I need to do now?

@lszomoru
Copy link
Member

@d1y, nothing :) I have posted your changes to this PR - #105219

@lszomoru lszomoru closed this Aug 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lszomoru lszomoru Awaiting requested review from lszomoru

Assignees

@lszomoru lszomoru

Labels
screencast-mode
Projects
None yet
Milestone
August 2020
Development

Successfully merging this pull request may close these issues.
3 participants
@d1y @lszomoru @joaomoreno