Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JS snippets trailing commas. #104153

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Fix JS snippets trailing commas. #104153

merged 1 commit into from
Aug 6, 2020

Conversation

mrnossiom
Copy link
Contributor

Fix JS snippets trailing commas, introduced by PR #100657 and observed by @abulka.

This PR fixes #104141

Fix JS snippets trailing commas, introduced by #100657 and observed by #104141.
Copy link
Contributor

@MrHeer MrHeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjbvz mjbvz added this to the July 2020 milestone Aug 6, 2020
@mjbvz mjbvz merged commit d213eb2 into microsoft:master Aug 6, 2020
@mjbvz
Copy link
Collaborator

mjbvz commented Aug 6, 2020

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trailing commas in bundled Javascript snippets break JSON parsing
4 participants