Use default flex values and use margins #104052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfongkye
changed the title
pfongkye
commented
Aug 5, 2020
| @@ -35,7 +35,7 @@ | |||
| } | |||
|
|
|||
| .monaco-workbench .repl .repl-tree .output.expression.value-and-source .value { | |||
| flex: 1; | |||
There was a problem hiding this comment.
Do we need a min-width for value? @isidorn
There was a problem hiding this comment.
I am fine either way, whatever you think behaves better.
I can also provide more feedback once I test this out
There was a problem hiding this comment.
I think we can keep it as is to avoid adding more constraints. Waiting for your feedback to see if it behaves as intended or if there are side effects that I haven't seen.
|
@pfongkye thanks a lot for this PR. This week we are wrapping up our release, which means we only take critical fixes in. Thus assigning this to August Milestone and I plan to review next week. |
|
@isidorn no worries 👍 |
|
I tried this out and seem to work just fine. Merging in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #102933