Allow to reopen closed webviews if the extension supports it #100979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! The fix looks good but I'm scheduling it for July instead of for the current release. This will give us a month to have the change in insiders and see if it causes any problems |
|
Thanks! |
gjsjohnmurray
pushed a commit
to gjsjohnmurray/vscode
that referenced
this pull request
Jul 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #97285
It let's you reopen closed webviews with Ctrl+Shift+T, such as markdown previews.
When you close an editor it is "disposed", but the check for whether you can restore a webview editor checked whether the editor is not disposed, which will never be the case.
Note that this does NOT solve #86864, because I'm not sure how to register a reviver for the release notes, but it is a necessary change before fixing that.