Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "pnpm" option to "npm.packageManager" setting #100654

Merged
merged 2 commits into from
Jul 1, 2020
Merged

Add "pnpm" option to "npm.packageManager" setting #100654

merged 2 commits into from
Jul 1, 2020

Conversation

Anoesj
Copy link
Contributor

@Anoesj Anoesj commented Jun 20, 2020

Expand options for "npm.packageManager" setting from:

  • "npm"
  • "yarn"

to:

  • "npm"
  • "yarn"
  • "pnpm"

Setting the "npm.packageManager" option to "pnpm" should make sure the NPM scripts explorer runs scripts with pnpm run {script name}.

Tested and seems to work, but since this is my first VSCode contribution, please check if I didn't forget anything.

This PR fixes #98305

@ghost
Copy link

ghost commented Jun 20, 2020

CLA assistant check
All CLA requirements met.

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll leave the final say to @egamma.

@alexr00 alexr00 added this to the June 2020 milestone Jun 22, 2020
@alexr00 alexr00 merged commit cac8f2e into microsoft:master Jul 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pnpm as an option for the npm.packageManager setting
2 participants