Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Tasks sync CustomExecution task should flush all data on close #90528

Closed
bpasero opened this issue Feb 12, 2020 · 6 comments
Closed

Web: Tasks sync CustomExecution task should flush all data on close #90528

bpasero opened this issue Feb 12, 2020 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug integration-test-failure web Issues related to running VSCode in the web

Comments

@bpasero
Copy link
Member

bpasero commented Feb 12, 2020

From: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=67363&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=f43345f0-e90d-5fa7-e3aa-7e223f6f3b99&l=656

 1) workspace-namespace Tasks sync CustomExecution task should flush all data on close:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
      at listOnTimeout (internal/timers.js:531:17)
      at processTimers (internal/timers.js:475:7)

@bpasero bpasero added broken-build integration-test-failure web Issues related to running VSCode in the web labels Feb 12, 2020
@bpasero bpasero changed the title Tasks sync CustomExecution task should flush all data on close Web: Tasks sync CustomExecution task should flush all data on close Feb 12, 2020
@alexr00
Copy link
Member

alexr00 commented Feb 12, 2020

FYI @Tyriar looks like it's happening again.

@Tyriar
Copy link
Member

Tyriar commented Feb 12, 2020

@bpasero was this flaky or failing all the time?

@bpasero
Copy link
Member Author

bpasero commented Feb 12, 2020

@Tyriar I think I have seen this at least twice in the past days. I am not sure it fails all the time. Note that our web integration tests only run as part of our product builds, so the frequency is a lot less.

@Tyriar Tyriar added this to the April 2020 milestone Apr 7, 2020
Tyriar added a commit that referenced this issue Apr 27, 2020
@Tyriar
Copy link
Member

Tyriar commented Apr 27, 2020

@alexr00 I've disabled these tests on web, I believe this flakiness is the same as in the terminal where some terminals just don't launch #96057

@Tyriar Tyriar modified the milestones: April 2020, May 2020 Apr 27, 2020
leilapearson pushed a commit to relmify/vscode that referenced this issue Apr 27, 2020
@Tyriar Tyriar modified the milestones: May 2020, Backlog May 11, 2020
@joaomoreno
Copy link
Member

@Tyriar Is this still an issue?

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Sep 22, 2020
@joaomoreno joaomoreno modified the milestones: Backlog, January 2021 Jan 7, 2021
@Tyriar Tyriar modified the milestones: January 2021, February 2021 Jan 25, 2021
@Tyriar Tyriar modified the milestones: February 2021, March 2021 Feb 22, 2021
@alexr00 alexr00 assigned alexr00 and unassigned alexr00 Mar 16, 2021
@alexr00
Copy link
Member

alexr00 commented Mar 16, 2021

Duplicate of #96057

@alexr00 alexr00 marked this as a duplicate of #96057 Mar 16, 2021
@alexr00 alexr00 closed this as completed Mar 16, 2021
@alexr00 alexr00 removed this from the March 2021 milestone Mar 16, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug integration-test-failure web Issues related to running VSCode in the web
Projects
None yet
Development

No branches or pull requests

4 participants