-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow "inline" menu contributions to quick pick items #88716
Comments
This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation. Happy Coding! |
This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation. Happy Coding |
🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation. Happy Coding! |
API proposal (is basically just exposing the existing internal API): interface QuickPickItem {
label: string;
// ...
/*
NEW
*/
buttons?: QuickInputButton[];
} export interface QuickPick<T extends QuickPickItem> extends QuickInput {
/**
* Current value of the filter text.
*/
value: string;
// ...
/**
* Buttons for actions in the UI.
*/
buttons: readonly QuickInputButton[];
/**
* An event signaling when a button was triggered.
*/
readonly onDidTriggerButton: Event<QuickInputButton>;
/**
* NEW
*/
readonly onDidTriggerItemButton: Event<QuickPickItemButtonEvent<T>>;
// ...
} New type: interface QuickPickItemButtonEvent<T extends QuickPickItem> {
button: QuickInputButton;
item: T;
} |
That’s great to see this feature request being reopened and moving to API proposal stage. I have opened a similar request last year (#96147), but just like this one, was closed due to not enough upvotes. Similar to this request, but on a keyboard approach, maybe microsoft/vscode-remote-repositories-github#2 could also take advantage if you expose Alt Modifiers, as requested in #18064. I know the Alt modifier is a not so powerful idea, but at least for those Looking forward for testing this API 😬 |
Reopening for finalization |
Finalized in f8ed49c |
@isidorn Wow! You work really fast! Just kidding, I didn't realize that this was already in. So I guess don't worry about this request 😄 |
@nturinski hahaha, as I said I am not aware of all the Quick Pick api features :) |
Similar to tree items, it would be great to be able to contribute commands to quick pick items
It is possible internally -- see:
Example use-case:
I would like to remove that button on top (since it is dependent on selection) and instead have it available on each stash entry. There are many other quickpick lists in GitLens where I would like to do a similar thing.
The text was updated successfully, but these errors were encountered: