Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Finalization of QuickInputItem inline actions API #137741

Closed
2 tasks done
TylerLeonhardt opened this issue Nov 23, 2021 · 1 comment
Closed
2 tasks done

Test: Finalization of QuickInputItem inline actions API #137741

TylerLeonhardt opened this issue Nov 23, 2021 · 1 comment

Comments

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Nov 23, 2021

Refs: #88716

Complexity: 4

Create Issue


This iteration, we introduced a new proposed quick pick API... Buttons on QuickPick Items!
image

definition:

        // extends what is in vscode.d.ts
	export interface QuickPickItem {
		buttons?: QuickInputButton[];
	}
        // extends what is in vscode.d.ts
	export interface QuickPick<T extends QuickPickItem> extends QuickInput {
		readonly onDidTriggerItemButton: Event<QuickPickItemButtonEvent<T>>;
	}
	export interface QuickPickItemButtonEvent<T extends QuickPickItem> {
		button: QuickInputButton;
		item: T;
	}

Please play around with this API addition and let me know what you think. Keep in mind, you may see this issue: #109969
Use keepScrollPosition property on the QuickPick to help with this.

Full steps if you need them:

these buttons are only supported on the window.createQuickPick object and not on the simpler showQuickPick

Useful stuff

	"enabledApiProposals": [
		"quickPickSeparators"
	],

Note the name of the proposed API is gathered from the file name in the vscode-dts folder

@aeschli
Copy link
Contributor

aeschli commented Nov 30, 2021

All works nicely! Looks like this is now already in vscode.d.ts, so I guess "enabledApiProposals": [: [ "quickPickSeparators" ] is not necessary.

@aeschli aeschli removed their assignment Nov 30, 2021
@sbatten sbatten removed their assignment Nov 30, 2021
@sbatten sbatten closed this as completed Nov 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants