Errors on fields with URI format not reported in Settings UI

[fbricon]

Found this issue while trying to set java.format.settings.url's format to uri (or uri-reference), in order to fix redhat-developer/vscode-java#1237

• VSCode Version: 1.42.0-insider (7e64866)
• OS Version: Mac OS 10.14.6

Steps to Reproduce:

1. Have a "mysetting" setting define "format":"uri" (as documented in https://code.visualstudio.com/api/references/contribution-points#contributes.configuration)
2. Open settings in UI, write then delete some value, no error is shown
3. Open settings.json, see that "mysetting":"" has a warning: String is not a URI: URI expected.

The validation error should be displayed in the UI too (as it does when using a validation pattern)

Does this issue occur when all extensions are disabled?: Maybe

[roblourens]

I guess we are missing that validation, also, the type of that setting should be ["string", "null"] if the default is "null".

          "type": "string",
          "description": "Specifies the url or file path to the [Eclipse formatter xml settings](https://github.com/redhat-developer/vscode-java/wiki/Formatter-settings).",
          "default": null,

[rzhao271]

@roblourens I can try working on this. Any code pointers, though? Not sure where to look.

[roblourens]

See https://github.com/Microsoft/vscode/blob/2445428308d74f1eedf73715809dca2d37e21c6d/src/vs/workbench/services/preferences/common/preferencesValidation.ts#L94-L94 for where these validations for the settings editor live. You need to figure out what validation the json language server does for "format": "uri". I assume that lives somewhere in https://github.com/microsoft/vscode-json-languageservice but I don't know where. I can help you if you can't find it.

[rzhao271]

Verifier:

1. Clone https://github.com/rzhao271/uri-format-setest
2. Run the extension and search uriformat in the settings editor
3. Try different values in the textbox that shows up. The empty string should not be accepted, and a string such as example.com should not be accepted. However, http:, http://, and http://example.com should be accepted.

[github-actions]

This bug has been fixed in to the latest release of VS Code Insiders!

@fbricon, you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text /verified to let us know. If not, please ensure you're on version bf21395 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!