Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[c#] Unexpected syntax color for nested namespace declarations #849

Closed
vbfox opened this issue Dec 1, 2015 · 2 comments
Closed

[c#] Unexpected syntax color for nested namespace declarations #849

vbfox opened this issue Dec 1, 2015 · 2 comments
Assignees
@aeschli
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
Backlog

Comments

@vbfox
Copy link
Contributor

vbfox commented Dec 1, 2015

2015-12-01 10_08_59-searchkey cs - rfq-hub - visual studio code

Namespaces contained in namespace declarations don't get any syntax coloration.

Additionally while the "Light" theme show a color for the namespace keyword different from the namespace name, the "Dark" one doesn't.

Version 0.12.2
@aeschli aeschli changed the title Unexpected syntax color for C# namespace declarations [c#] Unexpected syntax color for nested namespace declarations Dec 2, 2015
@aeschli
Copy link
Contributor

aeschli commented Dec 2, 2015

This issue was moved to atom/language-csharp#44

@aeschli aeschli mentioned this issue Dec 2, 2015
Closed
@aeschli aeschli closed this as completed Dec 2, 2015
@aeschli aeschli added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Dec 2, 2015
@aeschli aeschli reopened this Dec 2, 2015
@aeschli aeschli added the c# label Dec 2, 2015
@egamma egamma modified the milestone: Backlog Dec 10, 2015
@aeschli aeschli removed the bug Issue identified by VS Code Team member as probable bug label Mar 17, 2016
@aeschli
Copy link
Contributor

aeschli commented Mar 17, 2016

Now tracked in dotnet/vscode-csharp#101

@aeschli aeschli closed this as completed Mar 17, 2016
ivanz added a commit to ivanz/omnisharp-vscode that referenced this issue Aug 18, 2016
@ivanz
Fix highlighting of nested namespaces and using statements.
c1ed1cd 
Fixes dotnet#282, dotnet#849

Also the below which are tracked here: dotnet#101

microsoft/vscode#849
microsoft/vscode#848
@ivanz ivanz mentioned this issue Aug 18, 2016
Merged
ivanz added a commit to ivanz/omnisharp-vscode that referenced this issue Aug 18, 2016
@ivanz
Fix highlighting of nested namespaces and using statements.
8c77f7f 
Fixes dotnet#282, dotnet#849, dotnet#381

Also the below which are tracked here: dotnet#101

microsoft/vscode#849
microsoft/vscode#848
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@vbfox @egamma @aeschli