Suggestion: Use different icons for Extension View popular and recommended buttons

[gregvanl]

• VSCode Version:1.3.0-insiders
• OS Version:Windows 7

The flame icon for popular is confusing with the OmniSharp flame and perhaps offensive ("hot"). The gift icon is difficult to see and understand.

Suggestion: Use a star icon for popular. This matches the star ratings we show in the extension items.

Suggestion: Use a thumbs up hand image for recommended. The thumbs up image is very popular on GitHub and easily understood.

[bgashler1]

Yes, just saw these and agree these could be improved. We might want to make this part of #8017

[gregvanl]

Can we use octicon-star and octicon-thumbsup? These are already available in the included octicon css.

[bgashler1]

I emailed the icon team a request for new icons for this. Will update this issue when I hear back.

As placeholders in the interim, the star icon makes sense for popular, but thumbs-up does not. Thumbs up is often times associated with a direct action (+1 something, like something), so I wouldn't recommend it. Maybe you can use octicon-person temporarily for recommended.

In any case, we'll get some better icons for this soon.

[stevencl]

We will add an icon for View - clicking on this we show a list of actions - show popular, show recommended, show installed, show updates.
Clicking these actions will populate the textbox with the appropriate command to perform the search.
Brad will get assets from the VS icon team to deliver to Isidor.

[bgashler1]

Since all these commands are essentially filtering the list of all extensions by criteria we provide (such as whether it's installed, or whether it's popular or recommended), the icon team and I felt that a "Filter" icon would be appropriate.

I've attached the asset here.
Filter_16x.zip

[gregvanl]

Given that some of the actions are filtering (@popular, @recommended) and some are local (installed, installed and outdated), I think a filter icon is confusing. I'd prefer "..." which is clear to mean a dropdown will appear.

[bgashler1]

@gregvanl They're actually still filtered from all available extensions. If you were to scroll to each point in the entire list of extensions where you have installed an extension, you will see the same stuff.

[isidorn]

After getting negative feedback for the filter icon we have chosen to go with the elipses. Our concern with the elipses is that it goes against our design principle if it is the only action. So we also moved the clear action top level to also address #8386.
We felt this solution is a nice compromise between various suggestions.

[bpasero]

@isidorn make sure to fix the bad outline you now get that you removed the search attribute from input.