Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode.executeCodeActionProvider results seem to be missing their isPreferred property #78098

Closed
ypresto opened this issue Jul 29, 2019 · 0 comments · Fixed by #77999
Closed

vscode.executeCodeActionProvider results seem to be missing their isPreferred property #78098

ypresto opened this issue Jul 29, 2019 · 0 comments · Fixed by #77999
Assignees
@mjbvz
Labels
api bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
August 2019

Comments

@ypresto
Copy link
Contributor

ypresto commented Jul 29, 2019 •
edited
Loading

Issue Type: Bug

isPreferred version of #45124.
isPreferred property in result of vscode.executeCodeActionProvider is always undefined.

While it is not required to execute command, but is useful information.
(diagnostics is also missing but I ignored it because it is relatively large structure and more costly to implement type converters.)
@ypresto ypresto mentioned this issue Jul 29, 2019
Merged
@jrieken jrieken assigned mjbvz and unassigned jrieken Jul 30, 2019
ypresto added a commit to ypresto/vscode that referenced this issue Aug 8, 2019
@ypresto
Fixes microsoft#78098: Return isPreferred from vscode.executeCodeActi…
46c702b 
…onProvider
@mjbvz mjbvz added this to the August 2019 milestone Aug 12, 2019
@mjbvz mjbvz added api bug Issue identified by VS Code Team member as probable bug labels Aug 12, 2019
@jrieken jrieken added the verified Verification succeeded label Aug 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
api bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
August 2019
Development

Successfully merging a pull request may close this issue.

Let executeCodeActionProvider pass-through Selection object ypresto/vscode
3 participants
@ypresto @jrieken @mjbvz