Code lens can sometimes overlap with code

[eamodio]

Issue Type: Bug

I have only seen this with today's insiders (1.34), but sometimes the code lens overlaps with the editor content. See below:

VS Code version: Code - Insiders 1.34.0-insider (e88a32f, 2019-04-04T19:48:00.957Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4008)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	31.93GB (16.20GB free)
Process Argv
Screen Reader	no
VM	0%

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Add weight/priority to code lens providers (#28166)
• Alternative to double-click to close code lens (#60210)

[jrieken]

😱 what... @eamodio when you see this can you use the Element dev tool to inspect the html structure? Look for codelens-decoration and monaco-visible-content-widget classes

[eamodio]

The DOM of both good and bad code lens look identical -- and it looks like they are positioned appropriately, but the issue is that for some reason there is a missing view zone -- notice that there is no 2 view zone

Bad code lens:

Good code lens:

I think that this issue might be in some way related to #71707 since it feels like it only happens after a on-save format. Also switching to a different tab and back fixes it.

[jrieken]

This just happened to me with Insiders (without fix for #71707) and it seems that one view zone is missing. Below screen shot shows how 13 isn't there...

[eamodio]

I don't know what changed, but I'm seeing this issue happen A LOT more frequently. And I get tripped up, because sometimes it overlaps with a blank line, and it makes me think I'm missing a blank line in that space, causing me to add a new line and only then realize that there was one, it was just this issue.

[jrieken]

Nobody here having repro steps, right? Looking at code lens source this should only happens with an error somewhere - the calls to add and remove the viewzone/content widget pair always come together. One failing could prevent that other but it should surface as error...

[eamodio]

I don't have any steps that for sure make it happen, but I use both the typescript references code lens and GitLens' code lens (with a custom scope to make them appear on all blocks too):

"gitlens.codeLens.scopes": [
    "document",
    "containers",
    "blocks"
  ],

With that I see the issue very often... though as I'm trying to reproduce it with today's insiders I can't seem to get it to happen. 🤷‍♂

[jrieken]

@eamodio Errors on the console?

[eamodio]

@jrieken I can't be sure these lines were exactly related to this issue, but when I saw this issue, these were the last things in the console

workbench.main.js:239 [Extension Host] Registering disposable on object that has already been disposed. (at add (c:\Users\Eric\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:41:27))
t.log @ workbench.main.js:239
workbench.main.js:1406   ERR Data tree node not found: [object Object]: Error: Data tree node not found: [object Object]
    at Y.getDataNode (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:964:433)
    at Y.updateWidth (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:962:270)
    at e.s.instantiationService.createInstance.e [as updateWidth] (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:5250:648)
    at i.elementDisposable.i.label.onDidRender (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:5235:155)
    at d.fire (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:78:67)
    at D.render (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:4364:212)
    at D.notifyFileDecorationsChanges (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:4361:301)
    at _widgets.forEach.t (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:4358:644)
    at Array.forEach (<anonymous>)
    at _register.decorationsService.onDidChangeDecorations.e (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:4358:631)
    at e (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:74:506)
    at d.fire (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:78:67)
    at setTimeout (file:///C:/Users/Eric/AppData/Local/Programs/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:74:789)

[jrieken]

Unfortunately not, those errors come form the tree not being able to find nodes by id...

[DanTup]

I've been seeing this a lot lately, though can't see any obvious reason.

I have errors in the console, but I don't think they're related.

Could it be related to the caching of code lens that was added to reduce them jumping around?

That said, in the screenshot here the file was never modified, so I wouldn't expect the cache to have ever had only one of the two (line 10 and line 19 are the locations.. line 10 is hard to see as it overlaps void main).

[alexdima]

fyi @rebornix -- this is caused by the find widget which removes a view zone id created with the previous view from the new view. Steps:

1. Open fileA which has code lenses
2. Open fileB which does not have code lenses
3. Cmd+F to open the find widget (this will introduce view zone 1)
4. Open fileA again -- the find widget will remove view zone 1 incorrectly from the new view

[rebornix]

@alexandrudima thanks for the quick turn around