Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert null to undefined in workbench #70384

Closed
isidorn opened this issue Mar 13, 2019 · 3 comments
Closed

Convert null to undefined in workbench #70384

isidorn opened this issue Mar 13, 2019 · 3 comments
Assignees
@bpasero @isidorn @mjbvz
Labels
debt Code quality issues

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 13, 2019 •
edited by bpasero
Loading

  • | null should not be used
  • withUndefinedAsNull and withNullAsUndefined should not be needed

Related: #70020
@isidorn isidorn added the debt Code quality issues label Mar 13, 2019
@isidorn isidorn added this to the May 2019 milestone Mar 13, 2019
@isidorn isidorn modified the milestones: May 2019, April 2019 Mar 13, 2019
@bpasero bpasero modified the milestones: April 2019, On Deck Mar 29, 2019
@bpasero bpasero removed this from the On Deck milestone Jun 4, 2019
mjbvz added a commit that referenced this issue Sep 20, 2019
@mjbvz
Make getFocusedCodeEditor return undefined instead of null
b18ef0e 
#70384
mjbvz added a commit that referenced this issue Sep 20, 2019
@mjbvz
getActiveCodeEditor should return undefined instead of null
0fdba09 
#70384
mjbvz added a commit that referenced this issue Sep 20, 2019
@mjbvz
Use null instead of undefined for openCodeEditor
db11576 
#70384
@mjbvz mjbvz added this to the October 2019 milestone Sep 23, 2019
@bpasero
Copy link
Member

bpasero commented Oct 7, 2019

@mjbvz how do you plan to tackle this? There are still usages of null in hundreds of files in our code. Rather than doing an all or nothing approach, I typically just gradually convert to undefined while I refactor a piece of code.

@mjbvz
Copy link
Collaborator

mjbvz commented Oct 7, 2019

Yeah I don't think we want to make a big push to convert every null to undefined. Gradual conversion seems like the right approach to me too

Closing this issue

@mjbvz mjbvz closed this as completed Oct 7, 2019
@mjbvz mjbvz removed this from the October 2019 milestone Oct 7, 2019
@bpasero
Copy link
Member

bpasero commented Oct 8, 2019

@mjbvz also close #70020 ?

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@isidorn isidorn

@mjbvz mjbvz

Labels
debt Code quality issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bpasero @isidorn @mjbvz