Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug console: missing empty lines #69535

Closed
isidorn opened this issue Feb 27, 2019 · 4 comments
Closed

Debug console: missing empty lines #69535

isidorn opened this issue Feb 27, 2019 · 4 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues

Comments

@isidorn
Copy link
Contributor

isidorn commented Feb 27, 2019

console.log('hello');
console.log();
console.log('world');

There is no empty line between hello and world.
The issue is in the model which is being overly smart at removing empty lines here

Also check if the empty lines should say they do not have a dynamic height

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues debt Code quality issues labels Feb 27, 2019
@isidorn isidorn added this to the March 2019 milestone Feb 27, 2019
@isidorn isidorn self-assigned this Feb 27, 2019
@apolopena
Copy link

I tried this and do not get that behavior. Windows 10, Javascript(Babel)

@DanTup
Copy link
Contributor

DanTup commented Mar 20, 2019

Interestingly, if you right -click and go to "Copy All" and then paste somewhere, the newlines are all there!

@isidorn
Copy link
Contributor Author

isidorn commented Mar 20, 2019

I have pushed a simplification of how we are adding string repl elements.
However this is still not fully fixed since the console.log() does not send an output event to vscode. So forwarding @roblourens to check why console.log() does not send

When I run this using node, the empty line is nicely printed, so it seems that the node extension is holding out on output events that have an empty line maybe

@isidorn isidorn removed this from the March 2019 milestone Mar 20, 2019
@isidorn isidorn removed the debt Code quality issues label Mar 20, 2019
@isidorn isidorn assigned roblourens and unassigned isidorn Mar 20, 2019
@roblourens
Copy link
Member

I see the same in chrome devtools, no log message comes from node. It's kind of weird because console.log('') works but not console.log().

Debugged into the node code briefly and I don't see why it wouldn't send an empty message. It looks like the first argument is supposed to be required though: https://developer.mozilla.org/en-US/docs/Web/API/Console/log 🤷‍♂️

@isidorn isidorn self-assigned this Mar 22, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators May 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

No branches or pull requests

4 participants