-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugger commands sent to terminal get swallowed by previous terminal command #67692
Comments
See #67693 (comment) |
To help kickstart this again, the two ideas we had today for solving our debugger issues (if you all would be so gracious as to implement one of them 😉 ) are:
|
I haven't really looked into DAP much, but I had a look at how runInTerminal works. You might be able to pass in this as the first arg in the
Also created #77110 and #77111 after looking into the feature. |
Will that quote what's in those quotes correctly? E.g. if one of the args that you need has a space will that get quoted appropriately in that string you pass to |
@brettcannon provided the quotes get escaped correctly in debug I would think so. |
I've fixed issues #77110 and #77111, but they don't really help with the issue at hand. As @Tyriar has pointed out in #67693 (comment), there is not much we can do here. His recommendation in #67692 (comment) is the way to go. Quoting should work fine; if not, please file separate issues for them. |
Steps to Reproduce:
pipenv
print("Hello")
statementpipenv shell
pipenv shell
, causing the previously created environment to get activated in this new terminal.pipenv
environment will now be automatically selectedSelect Python Interpreter
pipenv shell
to activate the environment in the terminalpipenv shell
has not yet completed, and the commands sent by VSC debugger get swallowed upCauses:
Solutions:
runInTerminal
request (i.e. python extension re-invent the wheel).runInTerminal
request.Currently we can only send
args
, how about extending this to sendcommands
as well.This way the extension can send some custom commands that need to be executed before the VSC debugger commands. I.e. chain them together.
The text was updated successfully, but these errors were encountered: