Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep history in integrated terminal #6707

Closed
bpasero opened this issue May 24, 2016 · 3 comments
Closed

Keep history in integrated terminal #6707

bpasero opened this issue May 24, 2016 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label

Comments

@bpasero
Copy link
Member

bpasero commented May 24, 2016

It would be nice to keep some state of the terminal between restarts:

  • the history of commands typed
  • the last output
@bpasero bpasero added feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label labels May 24, 2016
@Tyriar
Copy link
Member

Tyriar commented May 24, 2016

Right now we don't mess with any input/output at all, it's all deferred to the shell. This works perfectly for bash, just how it works via gnome-terminal.

$ history
...
 1981  npm init
 1982  npm install open
 1983  node
 1984  history
 1985  ls
 1986  history
 1987  exit
 1988  history

What platform/shell did you have in mind specifically?

@Tyriar Tyriar added the info-needed Issue requires more information from poster label May 24, 2016
@bpasero
Copy link
Member Author

bpasero commented May 25, 2016

I am using the default terminal on Mac OS.

@Tyriar Tyriar removed the info-needed Issue requires more information from poster label May 25, 2016
@Tyriar
Copy link
Member

Tyriar commented May 25, 2016

Seems to work fine for me, to go to recent commands, ctrl+r to do a lookup. Regardless, this sort of stuff we can't mess with at the moment as input and output is done by external libs. Restoring any state would also be very difficult currently. There's the possibility for this to change in #6838

@Tyriar Tyriar closed this as completed May 25, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

2 participants