Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change keybinding for 'fold all' / 'unfold all' #6609

Closed
machv opened this issue May 21, 2016 · 5 comments
Closed

Change keybinding for 'fold all' / 'unfold all' #6609

machv opened this issue May 21, 2016 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@machv
Copy link

machv commented May 21, 2016

  • VSCode Version: 1.1.1
  • OS Version: Windows 10 1511 (Build 10586.318)

Steps to Reproduce:

  1. Use Czech (QWERTY) keboard layout.
  2. Press Ctrl-Alt-Shift-[ keys together (or AltGr-Shift-[)

Problem is that instead of just typing opening curly bracket { character in editor, VS Code collapses all definitions within curly brackets { } block. This behaviour makes writing source code using Czech QWERTY keyboard really uncomfortable.

Same problem is with closing curly bracket (Ctrl-Alt-Shift-]).

@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label May 23, 2016
@alexdima
Copy link
Member

@aeschli

Offending default keybindings:

{ "key": "ctrl+shift+alt+[",      "command": "editor.foldAll",
                                     "when": "editorFocus" },
{ "key": "ctrl+shift+alt+]",      "command": "editor.unfoldAll",
                                     "when": "editorFocus" },

ctrl+alt+ combinations should be avoided on Windows, as ctrl+alt+ is sent our way by Chromium when AltGr+ is pressed. AltGr+ is often used on various keyboard layouts.

@alexdima alexdima added this to the May 2016 milestone May 23, 2016
@alexdima alexdima assigned aeschli and unassigned alexdima May 23, 2016
@miloush
Copy link

miloush commented May 23, 2016

@alexandrudima note that this is not a Chromium thing, Ctrl+Alt is simply the same shift state as AltGr.

@aeschli
Copy link
Contributor

aeschli commented May 23, 2016

i changed it to:

{ "key": "ctrl+k ctrl+0",         "command": "editor.foldAll",
                                     "when": "editorFocus" },
{ "key": "ctrl+k ctrl+j",         "command": "editor.unfoldAll",
                                     "when": "editorFocus" },

@aeschli aeschli closed this as completed May 23, 2016
@aeschli aeschli assigned alexdima and unassigned aeschli May 26, 2016
@alexdima alexdima added the verified Verification succeeded label May 27, 2016
@alexdima
Copy link
Member

@aeschli Be sure to Release Note this change

@aeschli aeschli changed the title Type curly bracket using Czech (QWERTY) keyboard layout. New keybinding for 'fold all' / 'unfold all' May 29, 2016
@aeschli aeschli changed the title New keybinding for 'fold all' / 'unfold all' Change keybinding for 'fold all' / 'unfold all' May 29, 2016
@aeschli
Copy link
Contributor

aeschli commented May 29, 2016

@alexandrudima Thanks for the reminder, I added an entry to the release notes

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants