Getting SSL error on request

[jookyboi]

I AM THE CREATOR OF THE CACHER EXTENSION

• VSCode Version: 1.30.0-Insider
• OS Version: macOS 10.14.1

Steps to Reproduce:

1. Install Cacher from: https://marketplace.visualstudio.com/items?itemName=Cacher.cacher-vscode
2. Run command Cacher: Setup
3. Enter API Key: 6ada540a7faaf0eb, API Token: 1d28a604ceaa202375251033d9725125

Expect:
Toast message to show "Successfully set up Cacher.".

Actual:
Request to https://api.cacher.io/vscode/validate never seems to complete.

When I try to log the error in Debug mode, I get the following error:

Error: write EPROTO 4557563328:error:14077438:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert internal error:../../vendor/node/deps/openssl/openssl/ssl/s23_clnt.c:802:
setup.controller.js:80
	at _errnoException (util.js:1024:11)
	at WriteWrap.afterWrite [as oncomplete] (net.js:867:14)

This error does not occur on VSCode v1.29.1.

Does this issue occur when all extensions are disabled?: No

[rebornix]

Please file issue against the extension you are using.

Update

This is the same issue as GitHub Pull Request login issue.

[vscodebot]

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines.

Happy Coding!

[jookyboi]

Please re-open this issue. I am the creator of this extension and VSCode-Insider is causing for the request to fail for unknown reasons. @rebornix It doesn't make any sense for me to file an issue against my own extension.

If there is somewhere else I should be filing the issue, please let me know. I really think it is a VSCode issue as the extension has not changed between VSCode v1.29.1 and 1.30.0.

Also, if there is something I need to do as an extension developer to make this work, let me know.

[rebornix]

@jookyboi sorry, I misread the error message you sent. This is the same as GitHub Pull Request, which fails when it tries to validate access token, due to the same SSL error. We are already looking into this issue.

Error: write EPROTO 4557563328:error:14077438:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert internal error:../../vendor/node/deps/openssl/openssl/ssl/s23_clnt.c:802:

It's similar to nodejs/node#16196 but we are not sure yet.

[bpasero]

We are building exploration builds that use a much newer version of Electron (our UI framework). I wonder if this issue reproduces with one of these builds, could you try? Download:

• macOS: Download
• Linux: Download
• Windows: Download

[jookyboi]

@bpasero Thanks for posting. I've confirmed that the build you sent for macOS does indeed fix the request SSL issue for me.

[rebornix]

@jookyboi can you try if setting "http.systemProxy": "off" can fix the problem in Insiders?

[chrmarti]

@bpasero Is the setting enabled in the Electron 3 build?

[jookyboi]

@rebornix Turning system proxy to off (instead of the default force) does fix the problem in Insiders.

[bpasero]

@chrmarti I cannot answer your question because I do not know the answer

[chrmarti]

Also with Electron 3.

[chrmarti]

The affected servers are using SNI (server name identification), meaning: The client must send the server's name with the initial request, which the non-proxied code path was missing. Working on a fix.