Add Selection to Next Find Match selects an extra match

[tylerstillwater]

Issue Type: Bug

When using "Add Selection to Next Find Match" (default cmd+d on mac) to select the word under the cursor, a second match of the same word is selected when the search panel is open.

Video demonstration: http://cloud.stillwater.me/07969533b382/Screen%20Recording%202018-08-28%20at%2001.41%20PM.mov

VS Code version: Code 1.26.1 (493869e, 2018-08-16T18:31:26.156Z)
OS version: Darwin x64 17.7.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4960HQ CPU @ 2.60GHz (8 x 2600)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: unavailable_software video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Load (avg)	3, 3, 4
Memory (System)	16.00GB (0.20GB free)
Process Argv	/Applications/Visual Studio Code.app/Contents/MacOS/Electron
Screen Reader	no
VM	0%

Extensions (26)

Extension	Author (truncated)	Version
apib	Jar	0.0.1
close-all	ben	1.0.2
better-toml	bun	0.3.2
solargraph	cas	0.17.6
sql-formatter	cym	1.0.2
pgsql	dou	0.1.3
gitlens	eam	8.5.6
json-tools	eri	1.0.2
center-editor-window	kai	2.1.1
graphql-for-vscode	kum	1.12.1
python	ms-	2018.7.1
azure-account	ms-	0.4.3
cpptools	ms-	0.18.1
Go	ms-	0.6.88
vsliveshare	ms-	0.3.577
incrementor	nms	0.1.0
vscode-subword-navigation	ow	1.2.0
vscode-docker	Pet	0.1.0
ruby	reb	0.20.0
partial-diff	ryu	1.3.0
vscode-sql-beautify	sen	0.0.4
vscode-fileutils	sle	2.10.3
rewrap	stk	1.9.1
selectline-statusbar	tom	0.0.2
vscode-todo-highlight	way	1.0.4
change-case	wma	1.0.0

[alexdima]

@tylerb Thank you for reporting it! I also noticed this a couple of times and it was driving me crazy because I couldn't come up with reproducible steps.

[alexdima]

Steps:

• open find widget
• click on a word
• press ctrl+d or cmd+d
• two words are selected when only one should have been selected

[alexdima]

fyi @sandy081 I believe this got introduced with 83713d3 where before the find widget would react only to findInput.onInput, after the change the find widget reacts to all findInput.inputBox.onDidChange, including in the case that the find widget sets the search string programmatically.

[sandy081]

@alexandrudima Sorry for that. Thanks for the fix

[tylerstillwater]

@alexandrudima You're welcome for the report. Thanks for the fix! Is it possible to get this fix into my local environment right away? It is a constant nuisance for me.

[alexdima]

@tylerb It will come out with tomorrow's Insiders build

[tylerstillwater]

Excellent. Thanks!