Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace brackets as well upon creating a new branch #57373

Closed
brunofin opened this issue Aug 28, 2018 · 1 comment · Fixed by #57374
Closed

Replace brackets as well upon creating a new branch #57373

brunofin opened this issue Aug 28, 2018 · 1 comment · Fixed by #57374
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Milestone
September 2018

Comments

@brunofin
Copy link
Contributor

Upon creating a new branch, several symbols are replaced by - to avoid an invalid branch name.
Brackets are not replaced([ and ]) and they are often used in issue tracker tools to categorize a issue, i.e. ISSUE-6123 [MAP] Icons look weird is a valid issue name in JIRA that could be simply copy/pasted into the create branch dialog, but since the brackets are not replaced, it is needed to carefully remove them before pressing enter. This could help save a few seconds and some frustration :)
@vscodebot vscodebot bot added editor editor-bracket-matching Editor brace matching labels Aug 28, 2018
brunofin added a commit to Protolane/vscode that referenced this issue Aug 28, 2018
@brunofin
microsoft#57373 Replace brackets as well upon creating a branch
48ef510
@brunofin
Copy link
Contributor Author

@vscodebot this is not related to the text editor Brackets at all :)

@brunofin brunofin mentioned this issue Aug 28, 2018
Merged
@dbaeumer dbaeumer removed editor editor-bracket-matching Editor brace matching labels Aug 28, 2018
@joaomoreno joaomoreno added this to the Backlog milestone Aug 28, 2018
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug git GIT issues labels Aug 28, 2018
@joaomoreno joaomoreno modified the milestones: Backlog, September 2018 Sep 13, 2018
joaomoreno added a commit that referenced this issue Sep 13, 2018
@joaomoreno
Merge pull request #57374 from Protolane/enhancement/replace-brackets…
d9e0651 
…-too-upon-creating-new-branch

#57373 Replace brackets as well upon creating a branch
@RMacfarlane RMacfarlane added the verified Verification succeeded label Sep 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

Successfully merging a pull request may close this issue.

#57373 Replace brackets as well upon creating a branch Protolane/vscode
4 participants
@joaomoreno @dbaeumer @RMacfarlane @brunofin