Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom titlebar menu opens on click #56947

Closed
PeterWone opened this issue Aug 22, 2018 · 1 comment
Closed

Custom titlebar menu opens on click #56947

PeterWone opened this issue Aug 22, 2018 · 1 comment
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@PeterWone
Copy link

PeterWone commented Aug 22, 2018

Issue Type: Bug

Currently, the top level menu in the custom titlebar opens a submenu in response to a click event.

Correct behaviour under Windows is to open a submenu in response to a mousedown event. Compare the native top level menu, which opens submenus on a mousedown event.

Note that this implies that menu item invocation should triggered by mouseup rather than click, which is also not currently correctly implemented.

Version: 1.27.0-insider
Commit: 0779618
Date: 2018-08-21T08:48:57.835Z
Electron: 2.0.7
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

VS Code version: Code - Insiders 1.27.0-insider (0779618, 2018-08-21T08:48:57.835Z)
OS version: Windows_NT x64 10.0.17134

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 15.93GB (9.93GB free)
Process Argv C:\Users\PeterWone\AppData\Local\Programs\Microsoft VS Code Insiders\Code - Insiders.exe
Screen Reader no
VM 0%
Extensions (2)
Extension Author (truncated) Version
mssql ms- 1.4.0
csharp ms- 1.15.2
@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Aug 22, 2018
@JacksonKearl JacksonKearl assigned sbatten and unassigned Tyriar Aug 22, 2018
@sbatten
Copy link
Member

sbatten commented Aug 27, 2018

duplicate of #52907

@sbatten sbatten closed this as completed Aug 27, 2018
@sbatten sbatten added workbench-menu *duplicate Issue identified as a duplicate of another issue(s) and removed terminal General terminal issues that don't fall under another label labels Aug 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants