Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu: should open on mousedown and execute on mouseup #52907

Closed
bpasero opened this issue Jun 26, 2018 · 3 comments
Closed

Menu: should open on mousedown and execute on mouseup #52907

bpasero opened this issue Jun 26, 2018 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 26, 2018

Refs: #52854

I would expect this to work:

  • mouse down
  • move the mouse over a menu item
  • mouse up

=> action executes

@Tyriar
Copy link
Member

Tyriar commented Jun 26, 2018

👍 was about to create this

@octref
Copy link
Contributor

octref commented Jun 26, 2018

For me, the expected behavior is execution on mouse up. This is to give people a chance to regret if the misclick on an item - they can move mouse aside and abort the click. This is also how macOS's native dialog works.

@bpasero bpasero changed the title Menu: actions should execute on mouse down Menu: should open on mousedown and execute on mouseup Jun 27, 2018
@bpasero
Copy link
Member Author

bpasero commented Jun 27, 2018

It looks like the behaviour I want is to actually open the menu on mouse down but execute on mouse up, I will update the description.

@sbatten sbatten added the debt Code quality issues label Jul 3, 2018
@sbatten sbatten added this to the On Deck milestone Aug 8, 2018
@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug and removed debt Code quality issues labels Aug 27, 2018
@sbatten sbatten modified the milestones: On Deck, August 2018 Aug 27, 2018
@bpasero bpasero added the verified Verification succeeded label Aug 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants