Workbench should provide language agnostic actions to apply all quick fixes to a file

[dbaeumer]

• VSCode Version: 1.0.0
• OS Version:

Instead of extensions and language servers providing their own language specific actions the workbench should provide actions to apply all available quick fixes to a file. I think that this is even possible with the extension API today since we can ask for all code actions for a given range.

See microsoft/vscode-eslint#70.

[jrieken]

I think we should do that in the quick fix UI. When there is more than one action we should offer Apply all

[dbaeumer]

ESLint does exactly what you recommend. The use case for an action / command is to bind it to a short cut. Easier to trigger then setting a cursor on a problem, clicking the light bulb, .... I doubt that a lot of devs do F1 > .....

[jrieken]

stretch for april, tho rain on sunday

[dbaeumer]

Rain on Saturday and snow on Sunday :-)

[jrieken]

Saturday is this: http://www.redbull.com/us/en/bike/events/1331753879682/uci-mtb-world-cup-2016-round-2-cairns-australia

[dbaeumer]

Accepted :-)

[jrieken]

to clarify: we want a command that fetches and applies all code actions UI-less? not another entry in the code action UI, correct?

[jrieken]

Actually this isn't simple. The problem is that our CodeActions are just commands, not necessarily text edits. That mean we cannot run them all at once we because the change on which they have been computed might be different already. We have to do this:

1. ask for all code actions
2. run the first code actions
3. if there is another code action, repeat at Open Source VS Code #1

Then the challenge is to know when to stop. Because it doesn't mean that running that command make the code action go away...

[dbaeumer]

OK. See the problem. And we can't hook an handler for a language either since there can be more than one 'quick fix' provider per language. May be having a command 'ELint - fix all problems' is not a bad idea afterall.

[jrieken]

No action planned because there are challenges as outlined above

[dbaeumer]

Agree :-)