Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide shortcut for applying fixes #70

Closed
pke opened this issue Apr 21, 2016 · 12 comments
Closed

provide shortcut for applying fixes #70

pke opened this issue Apr 21, 2016 · 12 comments

Comments

@pke
Copy link

pke commented Apr 21, 2016

The lightbulb is nice (reminds me of Eclipse). How about a keyboard shortcut to apply the fixes:

  • MOD+SHIFT+1 Apply all fixes in file
  • MOD+1 Apply all fixes on current line
@vshabelnyk
Copy link

+1 from prev topic

@dbaeumer
Copy link
Member

This should be a general language independent actions. See microsoft/vscode#5650

@dbaeumer
Copy link
Member

A general language independent action is harder to archive then we thought. So we start with a specific elsint action which I added. I didn't bind a default short cut since almost all short cuts are taken in one way or another. Feel free to bind the command id "eslint.fixAllProblems" as you would like.

@empz
Copy link

empz commented Jun 22, 2016

@dbaeumer Is there a way to view the command id of a command? I spent a while looking for the eslint.fixAllProblems one until I found this issue.

@dbaeumer
Copy link
Member

capture

@dbaeumer
Copy link
Member

dbaeumer commented Jun 22, 2016

Working on code complete helping with this.

@empz
Copy link

empz commented Jun 22, 2016

Yes, but commands from extensions do not show up there.
i.e. eslint.fixAllProblems

@dbaeumer
Copy link
Member

@aeschli is this a know limitation. Should commands from extensions show up here as well.

@aeschli
Copy link

aeschli commented Jun 23, 2016

@jrieken Joh added that...

@jrieken
Copy link
Member

jrieken commented Jun 23, 2016

All minus those that start with an underscore since we like those to be kept private.

@emzero Note that the commands show up only after activating an extension. That could be why you don't see them

@gertcuykens
Copy link

gertcuykens commented Jul 31, 2016

Can fixAllProblems be done automatically when you format the code please?

image

@dbaeumer
Copy link
Member

I would rather have format and fix all on save then binding fix all to format.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants