Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[html] Please provide a built-in HTML.tmLanguage file #543

Closed
haoqunjiang opened this issue Nov 24, 2015 · 8 comments
Closed

[html] Please provide a built-in HTML.tmLanguage file #543

haoqunjiang opened this issue Nov 24, 2015 · 8 comments
Assignees
Labels
feature-request Request for new features or functionality html HTML support issues
Milestone

Comments

@haoqunjiang
Copy link

Lots of template languages extend html syntax.

Since popular text editors such as sublime text and atom usually have built-in HTML.tmLanguage file, most online syntax definition files just simply add an include: text.html.basic field in them.

However, Visual Studio Code does not have that built-in syntax definition file, thus forcing language extension authors to manually include an HTML.tmLanguage file. This feels awkward. I don't want to redefine HTML syntax in every single language extension I wrote.

So, please provide a built-in HTML syntax definition file for language extension authors!

@aeschli
Copy link
Contributor

aeschli commented Nov 24, 2015

Makes sense, will add.

@aeschli aeschli changed the title Please provide a built-in HTML.tmLanguage file [html] Please provide a built-in HTML.tmLanguage file Nov 24, 2015
@aeschli aeschli added the feature-request Request for new features or functionality label Nov 25, 2015
@egamma egamma added the languages-basic Basic language support issues label Nov 30, 2015
@aeschli aeschli added html HTML support issues and removed languages-basic Basic language support issues labels Nov 30, 2015
@aeschli aeschli added this to the Dec 2015 milestone Dec 2, 2015
@aeschli
Copy link
Contributor

aeschli commented Dec 2, 2015

Fix delivered

@Spown
Copy link

Spown commented Dec 19, 2015

Fix delivered

So what exactly have happened here? How to use it? I can't see anything in the update log and/ordocumentation.

@aeschli
Copy link
Contributor

aeschli commented Jan 4, 2016

The built in HTML extension now contains the html text mate grammar and declares the scope name text.html.basic.
The HTML editor mode in VSCode doesn't the text mate grammar yet, but other language extensions, that depend on the html text mate grammar to be present, profit from this. The issue description above is a good summary.

@abdelouahabb
Copy link

this feature will be usefull to develop extensions like Django/Jinja/Tornado templates support for example

@abdelouahabb
Copy link

@aeschli Emmet are not fired on langagues that use HTML (Jinja, Tornado, Django...etc), how to activate it?

In Atom, I added this atom-text-editor[data-grammar="text html tornado"]:not([mini]) in the keymaps, I checked the emmet docs and dident found the value to put in preferences?

@mrmlnc
Copy link
Contributor

mrmlnc commented Aug 11, 2016

@abdelouahabb, well, that's a work in progress. See #9500

@abdelouahabb
Copy link

@mrmlnc ah, thank you, excited to see it coming ^_^

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality html HTML support issues
Projects
None yet
Development

No branches or pull requests

6 participants