Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal.integrated.experimentalTextureCachingStrategy #52890

Closed
isidorn opened this issue Jun 26, 2018 · 1 comment
Closed

terminal.integrated.experimentalTextureCachingStrategy #52890

isidorn opened this issue Jun 26, 2018 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 26, 2018

Refs: #52836

Some feedback on the settings

  1. I do not like experimental in the name, in the description of this setting we should say it is experimental not in the name. I see we already do this for some other settings but I feel like it is wrong, because if one day we decide it is not experimental any more we have to change the setting name thus breaking behavior
  2. The reason why a user shuold change this is not really explained in the description
  3. Could we have "auto" as the default version so the terminal could automatically try to decide the best strategy
@isidorn isidorn added the terminal General terminal issues that don't fall under another label label Jun 26, 2018
@Tyriar
Copy link
Member

Tyriar commented Jun 26, 2018

  1. I expect the setting to go away and the only option/default being dynamic eventually.
  2. Will fix
  3. I don't think we need to do this given 1

@Tyriar Tyriar added this to the June 2018 milestone Jun 26, 2018
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Jun 26, 2018
@Tyriar Tyriar closed this as completed in 396ca1f Jun 26, 2018
Tyriar added a commit that referenced this issue Jun 26, 2018
@isidorn isidorn added the verified Verification succeeded label Jun 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants