Node LogPoints shows up as the VM source in debug console

[auchenberg]

Per conversation microsoft/vscode-node-debug#174

Node LogPoints shows up as a virtual source, and not a real source from where the LogPoint is set.

Example:

[roblourens]

The log event from Node contains the full stack, but the top frame is in an eval context. So I just have to identify a message from a logpoint and knock off the top frame.

I could do this by adding an extra argument to the end of the console.log that we send to the runtime with some identifiable string that identifies this log event as belonging to a logpoint. It's simple but the magic string would show up if you attach Chrome devtools at the same time.

Or I could look at the stack and check whether it comes from a line that we have an active logpoint on.

I'll go with the first for now as it's simpler and stateless.

[weinand]

Your approach works fine for the debug console but in the integrated terminal it results in this:

Instead of using $vscode_logpoint_expr$ you could use a few strange characters and the same number of backspace characters. This would result in something invisible in the integrated or external terminal ;-)

Or just use some NO-OP ANSI-Escape sequence...

[roblourens]

Dang... I'm worried that using special characters could cause weird issues somewhere. But it would be easier.

I could also use sourceURL on the script to tag it as ours.

[weinand]

"I could also use sourceURL on the script to tag it as ours."

I don't know how this works, but it sounds good!

Alternative:
Since you can find the eval script ID in the stack trace on the receiving side (where the Output event is generated), you could add the $vscode_logpoint_expr$ marker as a comment to the script and detect that later.

Or you could wrap the console.log in another function with a special marker name so you could find it easily in the stack.

[roblourens]

If you add a special comment to the end of an evaluated script, //# sourceURL="myscript" then it will be reported as having a url of myscript. F12 did this with all evaluated scripts so they could be filtered from the UI, I have an issue somewhere to do the same.

[auchenberg]

@roblourens Doesn't this change make all logpoints showup coming from the same file, and not the original?

[roblourens]

No, I use sourceURL to mark them as logpoints so I know to hide the eval stack frame. The user won't see it.

[auchenberg]

@roblourens Roger